Fix workflow parameters in scheduled events (PR 1476)#1633
Open
ciegler wants to merge 2 commits into
Open
Conversation
Arnei
approved these changes
Jul 7, 2026
Arnei
left a comment
Arnei
left a comment
Member
There was a problem hiding this comment.
Looks reasonable to me and works.
As this is a bug fix, I'd argue this could go into r/19.x.
Contributor
|
This pull request has conflicts ☹ |
ciegler
force-pushed
the
default-workflow-parameters
branch
from
July 14, 2026 13:57
945e027 to
55469b3
Compare
Member
|
We already tested this for version 20.x. |
Member
|
Considering it's targeting legacy now, I would like to see another quick round against 19. It shouldn't break anything, but those are famous last words... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is basically just reopening #1476.
I took over from @marwyg by rebasing his commit to the current admin-interface develop branch and using the existing
setDefaultConfigfromworkflowPanelUtilslike it was suggested in #1476.